Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(file-router): enable server fallback with client layout and empty client routes (#3280) (CP: 24.6) #3281

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@Lodin Lodin enabled auto-merge (squash) February 25, 2025 10:59
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (24.6@965cfc1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...e-router/src/runtime/RouterConfigurationBuilder.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             24.6    #3281   +/-   ##
=======================================
  Coverage        ?   92.66%           
=======================================
  Files           ?       85           
  Lines           ?     3161           
  Branches        ?      772           
=======================================
  Hits            ?     2929           
  Misses          ?      182           
  Partials        ?       50           
Flag Coverage Δ
unittests 92.66% <83.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lodin Lodin merged commit a3f1cf1 into 24.6 Feb 25, 2025
15 checks passed
@Lodin Lodin deleted the cherry-pick-3280-to-24.6-1740481038173 branch February 25, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants