-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improved endpoint detection #3255
base: main
Are you sure you want to change the base?
Conversation
When tested this together with Flow counterpart, the following error is thrown for me:
that means the class finder needs endpoint annotations in Flow's context initializer, but we cannot add them as Flow does not depend on Hilla. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3255 +/- ##
=======================================
Coverage 86.99% 86.99%
=======================================
Files 118 118
Lines 8292 8292
Branches 1269 1269
=======================================
Hits 7214 7214
Misses 1064 1064
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Fixes vaadin/flow#20983