Skip to content

Commit

Permalink
Address change requests
Browse files Browse the repository at this point in the history
  • Loading branch information
cromoteca committed Mar 3, 2025
1 parent d306f22 commit ce5f7e2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,6 @@ private static Path generateAotArtifacts(
var argsFile = engineConfiguration.getBuildDir()
.resolve("hilla-aot-args.txt");
Files.write(argsFile, settings);
var report = engineConfiguration.getBuildDir()
.resolve("hilla-aot-report.txt");

var javaExecutable = ProcessHandle.current().info().command()
.orElse(Path.of(System.getProperty("java.home"), "bin", "java")
Expand All @@ -113,6 +111,8 @@ private static Path generateAotArtifacts(
var process = new ProcessBuilder().inheritIO()
.command(javaExecutable, "@" + argsFile)
.redirectErrorStream(true).start();
var report = engineConfiguration.getBuildDir()
.resolve("hilla-aot-report.txt");
Files.copy(process.getInputStream(), report);
int exitCode = process.waitFor();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,9 @@ public BrowserCallableFinder getBrowserCallableFinder() {
} catch (Exception e) {
if (classFinder != null) {
LOGGER.info(
"AOT-based detection of browser-callable classes failed. Falling back to classpath scan.");
"AOT-based detection of browser-callable classes failed."
+ " Falling back to classpath scan."
+ " Enable debug logging for more information.");
return LookupBrowserCallableFinder
.findEndpointClasses(classFinder, this);
} else {
Expand Down

0 comments on commit ce5f7e2

Please sign in to comment.