Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satisfactory Update #8

Closed
wants to merge 1 commit into from
Closed

Conversation

Niborian
Copy link

I dont use this so It has not been tested I just changed versions to pull:

image:
repository: wolveix/satisfactory-server
pullPolicy: IfNotPresent
tag: v1@sha256:889a4735c2fec437ed1c75a27d45415a31d40faac6a68336cc88a98e3b2f9316

I dont use this so It has not been tested I just changed versions to pull:

image:
  repository: wolveix/satisfactory-server
  pullPolicy: IfNotPresent
  tag: v1@sha256:889a4735c2fec437ed1c75a27d45415a31d40faac6a68336cc88a98e3b2f9316
@Niborian
Copy link
Author

@v3DJG6GL Could you look at all the requests? 😊😅

@ikiris
Copy link

ikiris commented Sep 13, 2024

You should drop this one I've got a proper or going in for the changes made with 1.0 release

@Niborian
Copy link
Author

You should drop this one I've got a proper or going in for the changes made with 1.0 release

okay... could you provide any specific reasons for this recommendation?

I could change the digest to bump the version to v1.8.4 if needed since this isn’t approved yet. I noticed that the v1 tag seems to function like "latest," but I'm not entirely sure about this. Is there a reason not to use the v1 tag?
thanks 😊

@ikiris
Copy link

ikiris commented Sep 13, 2024

You should drop this one I've got a proper or going in for the changes made with 1.0 release

okay... could you provide any specific reasons for this recommendation?

I could change the digest to bump the version to v1.8.4 if needed since this isn’t approved yet. I noticed that the v1 tag seems to function like "latest," but I'm not entirely sure about this. Is there a reason not to use the v1 tag? thanks 😊

You can go look at my pull request. The app changed more than just version. The exposed api contract did as well.

@Niborian
Copy link
Author

@ikiris I dont quite get what you mean by "The exposed api contract did as well." and what that has todo and where you changed that, and ik it changed by more than one version... I updated to v1@digest... and v1 was updated so if I update the digest to the newer one I would basicly have version 1.8.4 (released 13h ago), Im just curious to what I should have done that I dident😅

@Niborian Niborian closed this Sep 13, 2024
@Niborian Niborian deleted the satisfactory-server branch September 13, 2024 23:43
@Niborian Niborian restored the satisfactory-server branch September 13, 2024 23:43
@Niborian Niborian deleted the satisfactory-server branch September 13, 2024 23:43
v3DJG6GL pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants