Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ux buttons btn unstyled, alignment, text #9485

Open
wants to merge 52 commits into
base: master
Choose a base branch
from

Conversation

bisht-richa
Copy link
Contributor

@bisht-richa bisht-richa commented Nov 18, 2024

What does this PR change?

  • A new button style was added: btn-tertiary.
  • Replaced btn-link with btn-tertiary
  • Fixed button labels consistency.
  • Corrected button placement for better usability and uniformity across the interface.

add description

GUI diff

No difference.

Before:
Screenshot 2024-11-18 at 13 56 58

Screenshot 2024-11-19 at 18 29 13 Screenshot 2024-12-05 at 16 57 59 Screenshot 2025-01-08 at 13 06 33

After:
Screenshot 2025-01-08 at 13 08 11

Screenshot 2024-12-16 at 15 08 33 Screenshot 2025-01-08 at 13 06 19

btn-tertiary
Screenshot 2025-01-17 at 13 05 10
Screenshot 2025-01-17 at 13 05 17

  • DONE

Documentation

  • No documentation needed

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: already covered

  • DONE

Links

Fixes: #26167
Port(s): # add downstream PR(s), if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

github-actions bot commented Nov 18, 2024

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9485/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9485/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Contributor

github-actions bot commented Nov 18, 2024

Suggested tests to cover this Pull Request
  • srv_manage_channels_page
  • min_config_state_channel
  • srv_cobbler_profile
  • min_cve_id_new_syntax
  • proxy_cobbler_pxeboot
  • srv_logfile
  • srv_delete_channel_with_tool
  • srv_create_repository
  • min_bootstrap_api
  • min_salt_minions_page
  • srv_enable_sync_products
  • min_salt_lock_packages
  • srv_cobbler_distro
  • min_salt_formulas
  • min_salt_install_with_staging
  • min_rhlike_salt
  • proxy_retail_pxeboot_and_mass_import
  • min_rhlike_remote_command
  • min_salt_migration
  • srv_menu
  • buildhost_docker_build_image
  • min_change_software_channel
  • srv_user_configuration_salt_states
  • min_ssh_tunnel
  • srv_dist_channel_mapping
  • srv_check_reposync
  • srv_group_union_intersection
  • srv_check_sync_source_packages
  • srv_manage_activationkey
  • srv_create_activationkey
  • minssh_move_from_and_to_proxy
  • srv_users
  • min_retracted_patches
  • srv_rename_hostname
  • srv_power_management
  • srv_cobbler_sync
  • proxy_container_retail_mass_import
  • proxy_branch_network
  • srv_osimage
  • srv_salt_download_endpoint
  • min_deblike_ssh
  • min_salt_openscap_audit
  • srv_organization_credentials
  • minssh_salt_install_package
  • sle_minion
  • srv_task_status_engine
  • proxy_container_branch_network
  • min_bootstrap_reactivation
  • srv_delete_channel_from_ui
  • min_rhlike_monitoring
  • srv_sync_fake_channels
  • allcli_action_chain
  • min_virthost
  • proxy_container
  • srv_scc_user_credentials
  • min_deblike_salt
  • minssh_bootstrap_api
  • min_salt_mgrcompat_state
  • buildhost_bootstrap
  • min_rhlike_openscap_audit
  • min_rhlike_ssh
  • allcli_software_channels_dependencies
  • min_docker_api
  • srv_add_rocky8_repositories
  • srv_change_password
  • buildhost_docker_auth_registry
  • srv_docker_advanced_content_management
  • srv_channels_add
  • min_check_patches_install
  • srv_push_package
  • proxy_container_retail_pxeboot
  • srv_activationkey_api
  • srv_reportdb
  • min_rhlike_salt_install_package_and_patch
  • srv_first_settings
  • min_project_lotus
  • srv_payg_ssh_connection
  • srv_user_preferences
  • min_cve_audit
  • min_bootstrap_script
  • min_salt_pkgset_beacon
  • min_salt_user_states
  • sle_ssh_minion
  • srv_docker
  • proxy_traditional
  • proxy_container_cobbler_pxeboot
  • srv_wait_for_reposync
  • min_timezone
  • srv_create_fake_channels
  • srv_docker_cve_audit
  • srv_datepicker
  • min_monitoring
  • proxy_as_pod_basic_tests
  • srv_power_management_api
  • srv_maintenance_windows
  • minssh_tunnel
  • min_deblike_remote_command
  • srv_power_management_redfish
  • srv_salt
  • min_bootstrap_ssh_key
  • srv_advanced_search
  • min_config_state_channel_subscriptions
  • allcli_reboot
  • srv_handle_software_channels_with_ISS_v2
  • minssh_action_chain
  • srv_virtual_host_manager
  • proxy_register_as_minion_with_script
  • srv_channel_api
  • srv_notifications
  • min_bootstrap_negative
  • srv_custom_system_info
  • srv_disable_local_repos_off
  • buildhost_osimage_build_image
  • allcli_update_activationkeys
  • min_salt_minion_details
  • minkvm_guests
  • srv_create_fake_repositories
  • min_salt_formulas_advanced
  • min_ansible_control_node
  • srv_patches_page
  • srv_handle_config_channels_with_ISS_v2
  • proxy_traditional_cobbler_pxeboot
  • allcli_overview_systems_details
  • min_deblike_salt_install_package
  • proxy_traditional_retail_pxeboot
  • minssh_ansible_control_node
  • srv_clone_channel_npn
  • srv_distro_cobbler
  • allcli_system_group
  • srv_sync_channels
  • srv_change_task_schedule
  • srv_disable_scheduled_reposync
  • min_deblike_salt_install_with_staging
  • srv_content_lifecycle
  • min_action_chain
  • min_move_from_and_to_proxy
  • allcli_sanity
  • allcli_config_channel
  • srv_monitoring
  • proxy_traditional_retail_mass_import
  • allcli_software_channels
  • min_custom_pkg_download_endpoint
  • srv_restart
  • min_activationkey
  • min_deblike_openscap_audit
  • min_recurring_action
  • min_salt_software_states
  • srv_check_channels_page
  • min_deblike_monitoring
  • srv_cobbler_buildiso
  • min_salt_install_package
  • srv_sync_products
  • min_empty_system_profiles
  • srv_mainpage

@bisht-richa bisht-richa changed the base branch from ux-buttons-component to master November 18, 2024 13:58
@bisht-richa bisht-richa changed the base branch from master to ux-buttons-component November 18, 2024 13:58
@bisht-richa bisht-richa force-pushed the ux-buttons-btn-unstyled-alignment-text branch from cc04c94 to d696f63 Compare November 18, 2024 14:11
@bisht-richa bisht-richa force-pushed the ux-buttons-component branch 2 times, most recently from 9a28a34 to 589f57d Compare November 26, 2024 11:01
Base automatically changed from ux-buttons-component to master November 28, 2024 15:37
@bisht-richa bisht-richa force-pushed the ux-buttons-btn-unstyled-alignment-text branch from 068415c to e52bfc0 Compare November 29, 2024 12:48
@bisht-richa bisht-richa marked this pull request as ready for review December 17, 2024 12:59
@bisht-richa bisht-richa requested review from a team as code owners December 17, 2024 12:59
@bisht-richa bisht-richa requested review from parlt91 and removed request for a team December 17, 2024 12:59
@bisht-richa bisht-richa force-pushed the ux-buttons-btn-unstyled-alignment-text branch from 163e690 to 1ccba9b Compare December 17, 2024 13:10
@bisht-richa bisht-richa changed the title WIP: Ux buttons btn unstyled, alignment, text Ux buttons btn unstyled, alignment, text Dec 18, 2024
Copy link
Contributor

@parlt91 parlt91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. The only point that needs clarification is the thing about the select all.
Really solid work. Thank you 😃

@bisht-richa bisht-richa dismissed stale reviews from parlt91 and Etheryte via 59ae854 February 12, 2025 13:21
@bisht-richa bisht-richa force-pushed the ux-buttons-btn-unstyled-alignment-text branch from 59ae854 to 87f7cd3 Compare February 12, 2025 13:33
@bisht-richa bisht-richa requested a review from Etheryte February 13, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants