-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ux buttons btn unstyled, alignment, text #9485
base: master
Are you sure you want to change the base?
Conversation
👋 Hello! Thanks for contributing to our project. You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9485/checks If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
Suggested tests to cover this Pull Request
|
cc04c94
to
d696f63
Compare
9a28a34
to
589f57d
Compare
068415c
to
e52bfc0
Compare
163e690
to
1ccba9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. The only point that needs clarification is the thing about the select all
.
Really solid work. Thank you 😃
java/code/src/com/redhat/rhn/frontend/strings/java/StringResource_en_US.xml
Outdated
Show resolved
Hide resolved
java/code/src/com/redhat/rhn/frontend/taglibs/ListDisplayTag.java
Outdated
Show resolved
Hide resolved
59ae854
to
87f7cd3
Compare
What does this PR change?
add description
GUI diff
No difference.
Before:
![Screenshot 2024-11-18 at 13 56 58](https://private-user-images.githubusercontent.com/18264463/401111324-2bcac8c6-9a93-4835-a4e7-d295ce775973.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NzczNzYsIm5iZiI6MTczOTY3NzA3NiwicGF0aCI6Ii8xODI2NDQ2My80MDExMTEzMjQtMmJjYWM4YzYtOWE5My00ODM1LWE0ZTctZDI5NWNlNzc1OTczLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDAzMzc1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdhNWNhNGM0OGUyNTZiZmQ2OGFhMmQ0NzkzNzg5NDE5YmI2NzFmN2Y0N2YyY2VlMWFjOGMxN2ZlZTgyZmU3YTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.TcGjOYLb_ra1mSnHi-y34zxZew3H-ASGaoypY0pYuTM)
After:
![Screenshot 2025-01-08 at 13 08 11](https://private-user-images.githubusercontent.com/18264463/401138490-7d9c1285-91ed-4d61-a9b5-ea1f29da7504.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NzczNzYsIm5iZiI6MTczOTY3NzA3NiwicGF0aCI6Ii8xODI2NDQ2My80MDExMzg0OTAtN2Q5YzEyODUtOTFlZC00ZDYxLWE5YjUtZWExZjI5ZGE3NTA0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDAzMzc1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNlNGExNjdmMWQ5YTNjOTEzNGQ1ZjY0YzNiYjBiNDQ1NjE3ODUyMGNhYTI0MTRkN2M4OTE4NTExMzM5MWI3NmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.UsNcrSE3mkd4nqXlWs7gebuedi9OEPt58uDc9bnOxpw)
btn-tertiary
![Screenshot 2025-01-17 at 13 05 10](https://private-user-images.githubusercontent.com/18264463/404293282-e0a534ad-afe8-4bd1-8935-049f87788269.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NzczNzYsIm5iZiI6MTczOTY3NzA3NiwicGF0aCI6Ii8xODI2NDQ2My80MDQyOTMyODItZTBhNTM0YWQtYWZlOC00YmQxLTg5MzUtMDQ5Zjg3Nzg4MjY5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDAzMzc1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRjOTkwZTczNTNmOGYzODJmMzA0ZWQzYjNlZWUyNzdjOGRlOTgxMjI3ZDg1MTAwMDcwM2U1MzE4ZjZjNTNhNmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.EqT_dSx9HIHYlU16A8WFRP0qWC-RzhqZ5IbDsrftfMc)
![Screenshot 2025-01-17 at 13 05 17](https://private-user-images.githubusercontent.com/18264463/404293310-cc4c514e-2eb6-4fe3-bfea-f7c7c8093cf9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NzczNzYsIm5iZiI6MTczOTY3NzA3NiwicGF0aCI6Ii8xODI2NDQ2My80MDQyOTMzMTAtY2M0YzUxNGUtMmViNi00ZmUzLWJmZWEtZjdjN2M4MDkzY2Y5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDAzMzc1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgzMGEwMTU1NTcxY2Y4MWJhYzI5YjUxMmE0OTA1MjkwNTEwN2M5YWYyOGY0YjVjNzRmNWRmYTA0YzNiYzIwYzEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.yKMFWKTitmVBu6xdG6ESjxj__aYDI-JsLHswH96YUtQ)
Documentation
No documentation needed
DONE
Test coverage
ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite
No tests: already covered
DONE
Links
Fixes: #26167
Port(s): # add downstream PR(s), if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!