-
Notifications
You must be signed in to change notification settings - Fork 54
implement locate and updatedb #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cool, thanks :) |
add please add tests :) |
afeae83
to
eeb7ab5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
==========================================
- Coverage 87.69% 87.30% -0.40%
==========================================
Files 31 35 +4
Lines 6893 6930 +37
Branches 324 353 +29
==========================================
+ Hits 6045 6050 +5
- Misses 617 628 +11
- Partials 231 252 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eeb7ab5
to
ae7b831
Compare
A couple notes:
|
src/db_tests.rs
Outdated
@@ -0,0 +1,79 @@ | |||
// Copyright 2017 Google Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Copyright 2017 Google Inc. |
be54aac
to
26982d5
Compare
closes #60
Given that locate has largely been replaced by (m|p)locate, I was unable to find a version of locate packaged for my system (latest Arch Linux), and the packaged version of updatedb does not use the LOCATE02 db format. When running updatedb from source, I encountered errors that were not immediately fixable. As such, this implementation is largely untested, but it's better to have something here to be improved upon.