You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, source code of IPhreeqc is vendored in PhreeqcRM, and it's hardcoded in the CMakeLists. Would it be possible to add an option to find an external IPhreeqc (with find_package(IPhreeqc REQUIRED)) and link to it (target_link_libraries(PhreeqcRM PRIVATE IPhreeqc::IPhreeqc))?
It's neater for package managers (it avoids ODR violations).
The text was updated successfully, but these errors were encountered:
Currently, source code of IPhreeqc is vendored in PhreeqcRM, and it's hardcoded in the CMakeLists. Would it be possible to add an option to find an external IPhreeqc (with
find_package(IPhreeqc REQUIRED)
) and link to it (target_link_libraries(PhreeqcRM PRIVATE IPhreeqc::IPhreeqc)
)?It's neater for package managers (it avoids ODR violations).
The text was updated successfully, but these errors were encountered: