Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CMake option to link to an external IPhreeqc #177

Open
SpaceIm opened this issue Aug 25, 2024 · 0 comments
Open

Add a CMake option to link to an external IPhreeqc #177

SpaceIm opened this issue Aug 25, 2024 · 0 comments

Comments

@SpaceIm
Copy link

SpaceIm commented Aug 25, 2024

Currently, source code of IPhreeqc is vendored in PhreeqcRM, and it's hardcoded in the CMakeLists. Would it be possible to add an option to find an external IPhreeqc (with find_package(IPhreeqc REQUIRED)) and link to it (target_link_libraries(PhreeqcRM PRIVATE IPhreeqc::IPhreeqc))?

It's neater for package managers (it avoids ODR violations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant