Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve local development experience #501

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Improve local development experience #501

merged 4 commits into from
Feb 6, 2025

Conversation

smlx
Copy link
Member

@smlx smlx commented Feb 4, 2025

  • update the build Makefile target to actually work with GoReleaser 2.
  • add a release-snapshot target to also build multiarch binaries and docker images.
  • document these targets in the README.

smlx added 2 commits February 4, 2025 15:06
* get runtime version information dynamically
* update command syntax for goreleaser 2.x
This target will build all architectures and docker images.
@smlx smlx changed the title fix build Improve local development experience Feb 4, 2025
@smlx smlx marked this pull request as ready for review February 4, 2025 07:52
@smlx smlx requested a review from shreddedbacon February 4, 2025 07:52
@smlx
Copy link
Member Author

smlx commented Feb 4, 2025

@shreddedbacon does this help with the local dev workflow you described?

@shreddedbacon
Copy link
Member

This is fine for building all three at the same time.

I can do this to just build one of the services without using goreleaser though, so might be nice to include this in the docs too.

CGO_ENABLED=0 go build -o dist/ssh-portal cmd/ssh-portal/*.go
docker buildx build --build-arg=BINARY=dist/ssh-portal -t ${IMAGE_REPO}/ssh-portal:${IMAGE_TAG} --platform=linux/amd64 .

@smlx
Copy link
Member Author

smlx commented Feb 5, 2025

Does that look better?

Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that works

@smlx smlx merged commit 8285ae8 into main Feb 6, 2025
12 checks passed
@smlx smlx deleted the fix-build branch February 6, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants