test: label checks #754
Draft
test: label checks #754
+96
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
added
needs-testing
next-release
and removed
needs-testing
next-release
labels
shreddedbacon
force-pushed
the
label-changes
branch
from
6cce491 to
53e921a
Compare
shreddedbacon
force-pushed
the
label-changes
branch
9 times, most recently
from
764f00d to
183cc3d
Compare
shreddedbacon
force-pushed
the
label-changes
branch
from
183cc3d to
a1b0f43
Compare
shreddedbacon
force-pushed
the
label-changes
branch
3 times, most recently
from
52644c7 to
fb7468e
Compare
tobybellwood
reviewed
Mar 3, 2025
| run: | | ||
| make install-lagoon | ||
| make -j8 -O fill-test-ci-values TESTS=[${{ matrix.test }}] | ||
|
|
||
| - name: Helm-install the test fixtures and fill lagoon-test/ci/linter-values.yaml (next-release) | ||
| if: | | ||
| (steps.list-changed.outputs.changed == 'true') && |
There was a problem hiding this comment.
this one might need to stay in to skip the tests if nothing has changed, but convert to an || instead
There was a problem hiding this comment.
yeah ill make it an ||
There was a problem hiding this comment.
The previous logic was "if changed & label exists" but that wouldn't fire if just the label was added or removed. i think it still makes sense to leave it as "if label exits" and ignore the "if changed" so it runs in both conditions
shreddedbacon
force-pushed
the
label-changes
branch
from
fb7468e to
340328c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.