chore: support broker tls #753
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
broker-tls
branch
7 times, most recently
from
be72da5 to
8296107
Compare
shreddedbacon
force-pushed
the
broker-tls
branch
3 times, most recently
from
91909a2 to
e5f6ed9
Compare
shreddedbacon
commented
Feb 28, 2025
| @@ -39,7 +39,7 @@ OVERRIDE_BUILD_DEPLOY_DIND_IMAGE = | |||
| OVERRIDE_ACTIVE_STANDBY_TASK_IMAGE = | |||
| # Overrides the image tag for amazeeio/lagoon-builddeploy whose default is | |||
| # the lagoon-build-deploy chart appVersion. | |||
| OVERRIDE_BUILD_DEPLOY_CONTROLLER_IMAGETAG = | |||
| OVERRIDE_BUILD_DEPLOY_CONTROLLER_IMAGETAG = rabbit-tls | |||
There was a problem hiding this comment.
required until uselagoon/remote-controller#282 merged/released
shreddedbacon
commented
Feb 28, 2025
shreddedbacon
force-pushed
the
broker-tls
branch
2 times, most recently
from
afa558a to
2ca8f79
Compare
shreddedbacon
commented
Mar 2, 2025
| -----END EC PRIVATE KEY----- | ||
|
|
||
| image: | ||
| tag: "rabbit-tls" |
There was a problem hiding this comment.
this is required until uselagoon/remote-controller#282 is merged/released
shreddedbacon
force-pushed
the
broker-tls
branch
from
2ca8f79 to
820d145
Compare
shreddedbacon
force-pushed
the
broker-tls
branch
from
820d145 to
c7138e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently contains mostly support for configuring
lagoon-build-deployandlagoon-corevia TLS. Will need to adapt to configurestorage-calculatorandinsights-remoteas well.There aren't any changes required in
uselagoon/lagoonto support TLS with broker, but there is some cleaning up required with the broker to remove some unused files, and maybe build in some development certificate generation as a fallback in the broker.They all have pending pullrequests to support talking to broker via TLS