Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove kube-rbac-proxy and use ginkgo tests #35

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jan 21, 2025

Removes kube-rbac-proxy from aergia and replaces it with WithAuthenticationAndAuthorization.

Removes legacy controller-test.sh and replaces it with ginkgo based tests, updates to the Makefile for local development tooling support.

@shreddedbacon shreddedbacon force-pushed the kube-rbac-proxy branch 11 times, most recently from a29adc3 to c233579 Compare January 21, 2025 05:37
@shreddedbacon
Copy link
Member Author

@CGoodwin90 can you see if you're able to run the test suite for this locally using make kind/test-e2e

@CGoodwin90
Copy link
Contributor

@CGoodwin90 can you see if you're able to run the test suite for this locally using make kind/test-e2e

Yep, that ran and passed.

@shreddedbacon
Copy link
Member Author

shreddedbacon commented Jan 21, 2025

Thanks!

Edit: I've asked for a review, but its mostly just shuffling code around to suit the project patterns for kubebuilder, and the replacement of the test-suite into ginkgo. Have a look, if you've got questions just ask.

@shreddedbacon shreddedbacon merged commit 8c49f8a into main Jan 22, 2025
8 checks passed
@shreddedbacon shreddedbacon deleted the kube-rbac-proxy branch January 22, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants