Merge pull request #160 from urbanopt/develop

Version 0.6.1

Author: kflemin

CHANGELOG.md

@@ -1,5 +1,12 @@
 # URBANopt GeoJSON Gem
 
+## Version 0.6.1
+
+Date Range: 04/27/21 - 04/29/21
+
+- Fixed [#155]( https://github.com/urbanopt/urbanopt-geojson-gem/issues/155 ), Adjacent buildings do not show up as shading objects
+- Fixed [#158]( https://github.com/urbanopt/urbanopt-geojson-gem/issues/158 ), Fix coordinates
+
 ## Version 0.6.0
 
 Date Range: 04/02/21 - 04/26/21

lib/urbanopt/geojson/feature.rb

@@ -261,10 +261,12 @@ def create_origin_lat_lon(runner)
       end
 
       ##
-      # Used to determine the centroid for the feature's coordinates.
+      # Used to determine the centroid for the feature's geojson coordinates.
       #
       # [Parameters]
       # * +vertices+ - The first set polygon vertices in the array of feature coordinates.
+      # [Returns]
+      # Returns Feature centroid coordinates [long, lat]
       def find_feature_center(vertices)
         number_of_locations = vertices.length
 
@@ -288,8 +290,9 @@ def find_feature_center(vertices)
         central_square_root = Math.sqrt(x * x + y * y)
         central_latitude = Math.atan2(z, central_square_root)
 
-        [central_latitude * 180 / Math::PI,
-         central_longitude * 180 / Math::PI]
+        [central_longitude * 180 / Math::PI,
+          central_latitude * 180 / Math::PI]
+         
       end
 
       private

lib/urbanopt/geojson/helper.rb

@@ -308,8 +308,11 @@ def self.process_other_buildings(building, other_building_type, other_buildings,
             # find the polygon of the other_building by passing it to the get_multi_polygons method
             other_building_points = building.other_points(other_building, other_height, origin_lat_lon, runner, zoning)
             shadowed = URBANopt::GeoJSON::Helper.is_shadowed(feature_points, other_building_points, origin_lat_lon)
+            if shadowed
+              runner.registerInfo("Feature #{other_building[:properties][:id]} is acting as shading object for #{building.id}")
+            end
             next unless shadowed
-            new_building = building.create_other_building(:space_per_building, model, origin_lat_lon, runner, zoning, other_building)
+            new_building = building.create_other_building(:space_per_building, model, origin_lat_lon, runner, zoning, 0, other_building)
             if new_building.nil? || new_building.empty?
               runner.registerWarning("Failed to create spaces for other building '#{name}'")
             end

lib/urbanopt/geojson/version.rb

@@ -40,6 +40,6 @@
 
 module URBANopt
   module GeoJSON
-    VERSION = '0.6.0'.freeze
+    VERSION = '0.6.1'.freeze
   end
 end