Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding an IHub interface #35

Open
Ninho67 opened this issue Aug 25, 2020 · 0 comments
Open

Consider adding an IHub interface #35

Ninho67 opened this issue Aug 25, 2020 · 0 comments

Comments

@Ninho67
Copy link

Ninho67 commented Aug 25, 2020

I love the initiative of having a lightweight, simple pubsub library. However, I would only use if it saves me from testing the whole publishing feature in my application.

If I had to wrap your lib in a component of my system, I wouldn't be able to mock your Hub component in my unit tests. In other words, I'd need to test the entire feature once again (and duplicate your unit tests ...).

Could you add an IHub to your project and save me the trouble ?
(or make the public methods virtual at least)

Thanks,
Cem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant