Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a wiki #22

Open
rafael-biz opened this issue Mar 26, 2019 · 3 comments
Open

Create a wiki #22

rafael-biz opened this issue Mar 26, 2019 · 3 comments

Comments

@rafael-biz
Copy link

Could you please create a wiki?

I had to look in source code to discover the Hub class and find out its methods.

@upta
Copy link
Owner

upta commented Mar 26, 2019

Technically speaking, using the Hub class itself isn't required (it wasn't originally even the intended usage pattern, was only added as an option later for using the library in DI scenarios)

Probably worth updating the README.md to mention it, if nothing else

@rafael-biz
Copy link
Author

It is because of the dependency injection.

The extensions are very cool, it is a very clever solution. I'm really impressed with its design. But its mechanism hides a singleton. For many scenarios it is fine having a singleton. For some others, it is bad.

So, I believe it worth mention it for those who are wondering how it works and how does pubsub fits in others projects. I personaly prefer avoid to use third party libraries unless strictly necessary.

Thanks for your help. It was enlightening.

@upta
Copy link
Owner

upta commented Mar 27, 2019

Oh, I totally agree, just saying the reason it wasn't documented was because it was added later and the docs never got updated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants