Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(date): accept date as datetime.date not just str #383

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

Danipulok
Copy link
Contributor

What this PR does?

  • Allow passing datetime.date as date;

What this PR does in details?

  • Add _format_date method that formats both str and datetime.date;
  • Update examples to use datetime.date;
  • Checked both old formats and datetime.date work;

@upbit
Copy link
Owner

upbit commented Jan 14, 2025

Great solution! Make compatible with various input types on the same parameter.

@upbit
Copy link
Owner

upbit commented Jan 14, 2025

The code style - related adjustments have been merged. Please resolve the conflicting files and submit again.

@upbit upbit merged commit 252543b into upbit:master Jan 15, 2025
0 of 2 checks passed
@Danipulok Danipulok deleted the feat/date-fmt branch January 18, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants