Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/typo ci #918

Merged
merged 7 commits into from
May 14, 2024
Merged

Feature/typo ci #918

merged 7 commits into from
May 14, 2024

Conversation

RayGuo-ergou
Copy link
Contributor

@RayGuo-ergou RayGuo-ergou commented May 13, 2024

Description

Typo check github action.

Followed from: #882

@zernonia
Copy link
Member

Thanks for picking this up @RayGuo-ergou ! I wonder how can you test the above yaa? I see that you have the workflow created but seems to be not running on pull_request: open tho?

this is default value to bypass eslint check

e.g. it's not allowed no value for `pull_request`
@RayGuo-ergou
Copy link
Contributor Author

RayGuo-ergou commented May 13, 2024

Sorry missed synchronize.

opend only triggered when open a pull request, because I pushed another commit after open the issue so it's not running the workflow.

btw types: [opened, reopened, synchronize] is default types for pull_request just to bypass eslint check.

Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks for the PR @RayGuo-ergou !

@zernonia zernonia merged commit 64d7eb2 into unovue:main May 14, 2024
1 check passed
@RayGuo-ergou RayGuo-ergou deleted the feature/typo_ci branch May 14, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants