Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aria-required not set to required prop value for Checkbox #1596

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

pmairoldi
Copy link
Contributor

Fixes #1595

This pull requests addresses the issue that the CheckboxRoot component always sets the aria-required attribute to false regardless of what the required props is.

@pmairoldi pmairoldi marked this pull request as ready for review January 30, 2025 18:29
Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the issue and the PR! 🚀

@zernonia zernonia merged commit 14da5f1 into unovue:main Jan 31, 2025
3 checks passed
Copy link

pkg-pr-new bot commented Jan 31, 2025

Open in Stackblitz

npm i https://pkg.pr.new/radix-vue@1596

commit: 7593636

@pmairoldi
Copy link
Contributor Author

pmairoldi commented Jan 31, 2025

Anytime 😃

I was wondering though, why implement all this instead of just using an input and using a sibling selector to style extra elements (https://v3.tailwindcss.com/docs/hover-focus-and-other-states#differentiating-peers)? Browser consistency?

Edit:
Thought about it and it makes perfect sense. I cannot imagine trying to reimplement the touch behaviours on mobile :P

@pmairoldi pmairoldi deleted the fix/1595 branch January 31, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants