refactor(shared): value utility (#148)

Fix: it not warning when passing invalid args or missing args
unnoq · Feb 16, 2025 · bf323bf · bf323bf
1 parent 3f40711
commit bf323bf
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/packages/shared/src/value.test-d.ts b/packages/shared/src/value.test-d.ts
@@ -19,4 +19,15 @@ describe('value', () => {
     expectTypeOf(value(() => Number(42))).toEqualTypeOf<Promise<number>>()
     expectTypeOf(value(async () => Number(42))).toEqualTypeOf<Promise<number>>()
   })
+
+  it('args', () => {
+    const v = {} as Value<string, [string, number]>
+    // @ts-expect-error missing args
+    value(v)
+    // @ts-expect-error missing args
+    value(v, 'hello')
+    value(v, 'hello', 123)
+    // @ts-expect-error wrong args
+    value(v, 'hello', '456')
+  })
 })
diff --git a/packages/shared/src/value.test.ts b/packages/shared/src/value.test.ts
@@ -5,10 +5,6 @@ it('value', async () => {
   expect(await value(() => 42)).toBe(42)
   expect(await value(async () => 42)).toBe(42)
 
-  expect(await value(() => ({
-    then: (resolve: (value: number) => void) => resolve(42),
-  }))).toBe(42)
-
   expect(await value(async () => ({
     then: (resolve: (value: number) => void) => resolve(42),
   }))).toBe(42)

diff --git a/packages/shared/src/value.ts b/packages/shared/src/value.ts
@@ -2,7 +2,10 @@ import type { Promisable } from 'type-fest'
 
 export type Value<T, TArgs extends any[] = []> = T | ((...args: TArgs) => Promisable<T>)
 
-export function value<T extends Value<any, TArgs>, TArgs extends any[] = []>(value: T, ...args: TArgs): Promise<T extends Value<infer U, any> ? U : never> {
+export function value<T, TArgs extends any[]>(
+  value: Value<T, TArgs>,
+  ...args: NoInfer<TArgs>
+): Promise<T extends Value<infer U, any> ? U : never> {
   if (typeof value === 'function') {
     return (value as any)(...args)
   }