Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation not displayed when the URL to shortern is blank #21

Open
darshanshah1996 opened this issue Oct 13, 2022 · 2 comments
Open

Validation not displayed when the URL to shortern is blank #21

darshanshah1996 opened this issue Oct 13, 2022 · 2 comments
Assignees
@darshanshah1996
Labels
☑️ assigned ✨ hacktoberfest ⭐ feature ✅ good first issue Good for newcomers

Comments

@darshanshah1996
Copy link

darshanshah1996 commented Oct 13, 2022 •
edited
Loading

Hi @unnikrishnan2002

Currently when user clicks on narrow link button without entering URL the request to endpoint https://nrly.herokuapp.com/api/url/narrowurl fails since the URL to shorten is not present

Thinking to add a toaster message to indicate user that the url cannot be blank. Let me know your thoughts on the UI

Can you assign the issue to me

image
@Yasshu55
Copy link
Collaborator

@darshanshah1996 Assigned it to you!

@unnikrishnan2002 unnikrishnan2002 added the ✅ good first issue Good for newcomers label Oct 14, 2022
@unnikrishnan2002
Copy link
Owner

@darshanshah1996 You are free to use bootstrap toaster or alert messages to implement the thing. It looks attractive also

@unnikrishnan2002 unnikrishnan2002 mentioned this issue Oct 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darshanshah1996 darshanshah1996

Labels
☑️ assigned ✨ hacktoberfest ⭐ feature ✅ good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@darshanshah1996 @unnikrishnan2002 @Yasshu55