-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fresh benchmarks on multiple layouts #142
Conversation
@Misty-W Is this still a draft or ready to merge? |
Okay cool. If that does not yield fruit, is there a reason we can't just use Qiskit's default mapping pass? |
With Qiskit's default mapping pass, UCC is almost but not quite as good as Qiskit when averaging across the benchmark layouts (see plots in above comment), so we need a better mapping pass. |
Since this is intended to fix #83 (i.e. create mapping benchmarks), I think it's okay if we merge in the code to generate these mapping benchmarks without merging the plots or adding them to our automated benchmark suite. @Misty-W Since you are now moving on to work on improving these mapping passes, let's complete this one and begin track your efforts toward mapping improvements in this issue: #85 |
d263689
to
44658d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #83.
Supersedes #120 .
SabreLayout
in UCC instead of the UCC custom pass of the same name, due to changes in QiskitResult
Follow-up:
Expand testing of existing Qiskit mapping and routing passes from optimization level 3 and non-default passes