Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh benchmarks on multiple layouts #142

Merged
merged 7 commits into from
Jan 6, 2025
Merged

Conversation

Misty-W
Copy link
Collaborator

@Misty-W Misty-W commented Dec 12, 2024

Fixes #83.
Supersedes #120 .

  • Includes recent updates to Qiskit, UCC, and the UCC benchmarks
  • Uses Qiskit SabreLayout in UCC instead of the UCC custom pass of the same name, due to changes in Qiskit
  • Fixes the order of mapping, routing, and basis translation in the PyTket benchmarking function

Result

image

Follow-up:
Expand testing of existing Qiskit mapping and routing passes from optimization level 3 and non-default passes

@Misty-W
Copy link
Collaborator Author

Misty-W commented Dec 20, 2024

Best layout benchmarks to date, using Qiskit level 3 mapping and routing passes along with UCC defaults- gate counts are nearly on par.
image

For reference, recent benchmarks on all-to-all connectivity:
image

Also, latest data on compile time to show Qiskit runtime improvement:

image

@jordandsullivan
Copy link
Collaborator

@Misty-W Is this still a draft or ready to merge?

@Misty-W
Copy link
Collaborator Author

Misty-W commented Jan 2, 2025

@Misty-W Is this still a draft or ready to merge?

I would wait to merge until we can show UCC is better on average wrt gate count across different layouts. I'm currently setting up a test of the mapomatic library to see if it provides a worthwhile improvement.

@jordandsullivan
Copy link
Collaborator

Okay cool. If that does not yield fruit, is there a reason we can't just use Qiskit's default mapping pass?

@Misty-W
Copy link
Collaborator Author

Misty-W commented Jan 2, 2025

With Qiskit's default mapping pass, UCC is almost but not quite as good as Qiskit when averaging across the benchmark layouts (see plots in above comment), so we need a better mapping pass.

@jordandsullivan
Copy link
Collaborator

Since this is intended to fix #83 (i.e. create mapping benchmarks), I think it's okay if we merge in the code to generate these mapping benchmarks without merging the plots or adding them to our automated benchmark suite.

@Misty-W Since you are now moving on to work on improving these mapping passes, let's complete this one and begin track your efforts toward mapping improvements in this issue: #85

@Misty-W Misty-W force-pushed the mapping-and-routing-refresh branch from d263689 to 44658d3 Compare January 3, 2025 22:41
@Misty-W Misty-W marked this pull request as ready for review January 4, 2025 01:02
Copy link
Collaborator

@jordandsullivan jordandsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Misty-W Misty-W merged commit 83d2d0c into main Jan 6, 2025
1 check passed
@Misty-W Misty-W deleted the mapping-and-routing-refresh branch January 6, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add benchmark for qubit mapping
2 participants