Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes json schema issue #1686

Closed
wants to merge 7 commits into from

Conversation

imseananriley
Copy link

Fixes #1677

Signed-off-by: imseananriley <seanan.riley@berkeley.edu>
@cosmicBboy
Copy link
Collaborator

Thanks @imseananriley ! Do you mind rebasing this onto the main branch? Added some fixes to support numpy 2.

Looks like this PR caused some pydantic tests to fail:

=========================== short test summary info ============================
FAILED tests/core/test_decorators.py::test_check_types_non_dataframes - pydantic_core._pydantic_core.ValidationError: 2 validation errors for UnionDfIntTypesPydanticCheck
val.list[typed-dict].0
  Input should be a valid dictionary [type=dict_type, input_value='a', input_type=str]
    For further information visit https://errors.pydantic.dev/2.3/v/dict_type
val.int
  Input should be a valid integer [type=int_type, input_value=   a
0  0
1  0, input_type=DataFrame]
    For further information visit https://errors.pydantic.dev/2.3/v/int_type
FAILED tests/core/test_pydantic.py::test_typed_dataframe - pydantic_core._pydantic_core.ValidationError: 1 validation error for TypedDfPydantic
df.0
  Input should be a valid dictionary [type=dict_type, input_value='str_col', input_type=str]
    For further information visit https://errors.pydantic.dev/2.3/v/dict_type
FAILED tests/core/test_pydantic.py::test_invalid_typed_dataframe - pandera.errors.SchemaInitError: Found missing annotations: ['str_col']
========== 3 failed, 1766 passed, 3 skipped, 1028 warnings in 53.51s ===========

You can follow these steps to make sure unit tests are passing locally

imseananriley and others added 4 commits June 23, 2024 14:39
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: Billy Vinning <b.vinning@outlook.com>
* fix formatting errors

Signed-off-by: Alp Aribal <alparbal@gmail.com>

* rm duplicated field

Signed-off-by: Alp Aribal <alparbal@gmail.com>

* add missing fields

Signed-off-by: Alp Aribal <alparbal@gmail.com>

* reorder fields based on order in init

Signed-off-by: Alp Aribal <alparbal@gmail.com>

---------

Signed-off-by: Alp Aribal <alparbal@gmail.com>
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.45%. Comparing base (812b2a8) to head (12e13a1).
Report is 102 commits behind head on main.

Current head 12e13a1 differs from pull request most recent head f667fb3

Please upload reports for the commit f667fb3 to get more accurate results.

Files Patch % Lines
pandera/typing/pandas.py 20.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (812b2a8) and HEAD (12e13a1). Click for more details.

HEAD has 51 uploads more than BASE | Flag | BASE (812b2a8) | HEAD (12e13a1) | |------|------|------| ||48|99|
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1686       +/-   ##
===========================================
- Coverage   94.28%   72.45%   -21.84%     
===========================================
  Files          91      117       +26     
  Lines        7013     8679     +1666     
===========================================
- Hits         6612     6288      -324     
- Misses        401     2391     +1990     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: imseananriley <seanan.riley@berkeley.edu>
@imseananriley imseananriley deleted the bugfix/1677 branch June 24, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pydantic compatibility issue
4 participants