-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes json schema issue #1686
Fixes json schema issue #1686
Conversation
Signed-off-by: imseananriley <seanan.riley@berkeley.edu>
Thanks @imseananriley ! Do you mind rebasing this onto the Looks like this PR caused some pydantic tests to fail:
You can follow these steps to make sure unit tests are passing locally |
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: Billy Vinning <b.vinning@outlook.com>
* fix formatting errors Signed-off-by: Alp Aribal <alparbal@gmail.com> * rm duplicated field Signed-off-by: Alp Aribal <alparbal@gmail.com> * add missing fields Signed-off-by: Alp Aribal <alparbal@gmail.com> * reorder fields based on order in init Signed-off-by: Alp Aribal <alparbal@gmail.com> --------- Signed-off-by: Alp Aribal <alparbal@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1686 +/- ##
===========================================
- Coverage 94.28% 72.45% -21.84%
===========================================
Files 91 117 +26
Lines 7013 8679 +1666
===========================================
- Hits 6612 6288 -324
- Misses 401 2391 +1990 ☔ View full report in Codecov by Sentry. |
Signed-off-by: imseananriley <seanan.riley@berkeley.edu>
Fixes #1677