Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial for building ICU4X data #664

Closed
Tracked by #1110
sffc opened this issue Apr 20, 2021 · 4 comments
Closed
Tracked by #1110

Add tutorial for building ICU4X data #664

sffc opened this issue Apr 20, 2021 · 4 comments
Assignees
Labels
C-data-infra Component: provider, datagen, fallback, adapters S-small Size: One afternoon (small bug fix or enhancement) T-docs-tests Type: Code change outside core library

Comments

@sffc
Copy link
Member

sffc commented Apr 20, 2021

We have documentation scattered around a bit. We should update the data_provider.md tutorial to document the full lifecycle of ICU4X data with a focus on clients of ICU4X.

Blocked on #78

@sffc sffc added T-docs-tests Type: Code change outside core library C-data-infra Component: provider, datagen, fallback, adapters S-small Size: One afternoon (small bug fix or enhancement) labels Apr 20, 2021
@sffc sffc added this to the ICU4X 0.3 milestone Apr 20, 2021
@sffc sffc self-assigned this Apr 20, 2021
@sffc sffc modified the milestones: ICU4X 0.3, 2021 Q2-m3 May 13, 2021
@sffc sffc mentioned this issue Jul 21, 2021
7 tasks
@sffc sffc modified the milestones: 2021 Q3-m1, ICU4X 0.4 Aug 11, 2021
@sffc
Copy link
Member Author

sffc commented Oct 21, 2021

Moving this from the #873 meta-issue to the #1110 meta-issue.

@sffc sffc mentioned this issue Oct 21, 2021
8 tasks
@sffc sffc modified the milestones: ICU4X 0.4, ICU4X 0.5 Oct 21, 2021
@sffc sffc modified the milestones: ICU4X 0.5, ICU4X 0.6 Jan 27, 2022
@sffc sffc modified the milestones: ICU4X 0.6, ICU4X 1.0 (Polish) May 25, 2022
@sffc
Copy link
Member Author

sffc commented May 28, 2022

The data build process for client Rust crates can be the following, based on discussion with @robertbastian:

  1. build.rs invokes datagen with a list of keys and locales
  2. An integration test verifies that the extracted keys are consistent with the keys that were passed to datagen

We may want to move toward a datagen.toml file that contains the list of keys, locales, CLDR version, etc., so that:

  1. It can be read from both build.rs and the integration test
  2. To better separate code (build.rs) and data (datagen arguments)

@sffc
Copy link
Member Author

sffc commented Sep 26, 2022

This should be done before the blog post goes out.

@sffc sffc assigned robertbastian and unassigned sffc Oct 13, 2022
@robertbastian
Copy link
Member

Fixed by #2678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-data-infra Component: provider, datagen, fallback, adapters S-small Size: One afternoon (small bug fix or enhancement) T-docs-tests Type: Code change outside core library
Projects
None yet
Development

No branches or pull requests

2 participants