Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve icu4x_key_extract #1533

Closed
robertbastian opened this issue Jan 23, 2022 · 4 comments · Fixed by #1950
Closed

Improve icu4x_key_extract #1533

robertbastian opened this issue Jan 23, 2022 · 4 comments · Fixed by #1950
Assignees
Labels
C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt

Comments

@robertbastian
Copy link
Member

In #1480 we use strings, which might not be available on all systems.

@robertbastian robertbastian self-assigned this Jan 23, 2022
@sffc
Copy link
Member

sffc commented Jan 25, 2022

It makes me uneasy to think that a pivotal part of the ICU4X data pipeline rests on piping strings to sed. I'd rather have a tool that takes an executable and returns the key list.

@robertbastian
Copy link
Member Author

I wonder if we can exploit the linker somehow. Like putting all the path strings in one section and then looking at what appears there. Unfortunately there's rust#70239

@sapriyag
Copy link
Contributor

what should be the size of this issue? S-medium or S-large? Can you please add the size label to this issue.

@sffc sffc added C-data-infra Component: provider, datagen, fallback, adapters T-techdebt Type: ICU4X code health and tech debt S-medium Size: Less than a week (larger bug fix or enhancement) labels Apr 28, 2022
@sffc sffc added this to the ICU4X 1.0 milestone Apr 28, 2022
@sffc
Copy link
Member

sffc commented May 25, 2022

For the purposes of 1.0, we want this to be well-documented and runnable by users without having to clone the icu4x project repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants