Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the fixed ResourceCategory enum? #1192

Closed
sffc opened this issue Oct 20, 2021 · 0 comments · Fixed by #1511
Closed

Remove the fixed ResourceCategory enum? #1192

sffc opened this issue Oct 20, 2021 · 0 comments · Fixed by #1511
Assignees
@sffc
Labels
C-data-infra Component: provider, datagen, fallback, adapters S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Milestone
2021 Q4 0.5 Sprint F

Comments

@sffc
Copy link
Member

sffc commented Oct 20, 2021

It's not clear that the ResourceCategory enum is actually achieving anything for us. It requires updating the icu_provider crate whenever a new component is added, which is not ideal. Consider replacing ResourceCategory with a TinyStr16 newtype.
@sffc sffc added C-data-infra Component: provider, datagen, fallback, adapters T-techdebt Type: ICU4X code health and tech debt S-small Size: One afternoon (small bug fix or enhancement) labels Oct 20, 2021
@sffc sffc added this to the 2021 Q4 0.5 Sprint A milestone Oct 20, 2021
@sffc sffc self-assigned this Oct 20, 2021
@sffc sffc added the discuss Discuss at a future ICU4X-SC meeting label Nov 18, 2021
@sffc sffc modified the milestones: 2021 Q4 0.5 Sprint B, ICU4X 0.5 Nov 18, 2021
@sffc sffc removed the discuss Discuss at a future ICU4X-SC meeting label Jan 20, 2022
@sffc sffc modified the milestones: ICU4X 0.5, 2021 Q4 0.5 Sprint F Jan 20, 2022
@sffc sffc linked a pull request Jan 20, 2022 that will close this issue
Re-write ResourceKey #1511
Merged
@sffc sffc closed this as completed Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sffc sffc

Labels
C-data-infra Component: provider, datagen, fallback, adapters S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Projects
None yet
Milestone
2021 Q4 0.5 Sprint F
Development

Successfully merging a pull request may close this issue.

Re-write ResourceKey sffc/omnicu
1 participant
@sffc