CLDR-18402 CLDRConfig to always set CLDR_DIR=. with a warning #4482
+22
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- .. if the current dir seems to be a CLDR dir - we already do this for the .jar, but do this everywhere (such as from mvn:exec)
srl295
commented
Mar 11, 2025
| @@ -23,6 +23,7 @@ | |||
| import org.unicode.cldr.icu.dev.test.TestFmwk; | |||
| import org.unicode.cldr.icu.dev.test.TestLog; | |||
| import org.unicode.cldr.test.CheckCLDR.Phase; | |||
| import org.unicode.cldr.test.SubmissionLocales; | |||
There was a problem hiding this comment.
this is a spotless change - SubmissionLocales is mentioned in a javadoc comment somewhere.
srl295
commented
Mar 11, 2025
|
|
||
| /** | ||
| * If CLDR_DIR is not set as a system property, try to set it. This does not invoke the | ||
| * CLDRConfig mechanism, and so would be ignored if run from (say) the SurveyTool environment. |
There was a problem hiding this comment.
in the survey tool, the explicit property file would override the environment var anyway.
btangmu
approved these changes
Mar 11, 2025
macchiati
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18402
ALLOW_MANY_COMMITS=true