Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor storage service to improve modularity and error handling #4

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

ashleythedeveloper
Copy link
Collaborator

Description

This PR refactors the storage service to improve modularity, error handling, and type safety. It also adds new functionality for document storage and updates the cryptography service.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

N/A

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📕 storybook
  • 🙅 no documentation needed

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 94.05% 158/168
🟢 Branches 100% 29/29
🟢 Functions 82.61% 19/23
🟢 Lines 93.9% 154/164

Test suite run success

37 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 1820ec2

Copy link
Contributor

github-actions bot commented Sep 23, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 94.05% 158/168
🟢 Branches 100% 29/29
🟢 Functions 82.61% 19/23
🟢 Lines 93.9% 154/164

Test suite run success

37 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 320b34e

README.md Outdated Show resolved Hide resolved
namhoang1604
namhoang1604 previously approved these changes Sep 27, 2024
Copy link
Contributor

@namhoang1604 namhoang1604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@huynguyen-hl huynguyen-hl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashleythedeveloper ashleythedeveloper merged commit 94317fc into next Sep 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants