ci: push docker image #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success23 tests passing in 8 suites. Report generated by 🧪jest coverage report action from 279716f |
|
@ashleythedeveloper, the Dockerfile is using build args now instead of env variables. That means that if we want use the other values rather then default, they need to be provided as build args during build. I assume that they need to be dynamic and therefore something like uncefact/project-vckit@234c72e needs to be done for the Dockerfile in this repo. |
kshychko
requested changes
Aug 6, 2024
ashleythedeveloper
force-pushed
the
ci/push_docker_image
branch
from
8d98de8 to
279716f
Compare
kshychko
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new GitHub Actions workflow to build and push Docker images to the GitHub Container Registry.
Mobile & Desktop Screenshots/Recordings
What type of PR is this? (check all applicable)
Added tests?
Added to documentation?