Improvements to the codebase #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't know why it needed to merge it in, but I kept all of my changes Conflicts: src/DirectoryConverter.ump src/Elements.ump src/TemplateConverter.ump
Diusrex
changed the title
Diusrex
changed the title
|
Will also be following up with a documentation update on this and the main umple repository in the next day and a half. |
|
|
||
|
|
||
| // These are all constants for parsing the JET templates | ||
| class JETConstants { |
|
👍 following adjustments from my comments! |
|
👍 from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the main code improvement pull request I will do. Also fixed some of the existing code, which resulted in many changed tests.
Please note that the first two commits were added in an earlier pull request, but apparently diverged from my local. Was luckily able to easily merge them in
Will do one more smaller pull request tomorrow for a refactoring of the parse*Blocks. Will put them into a class.