You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For example, the Java test template files association_AddImmutableUnidirectionalMany.jet does not have a newline at the end, while association_SetOptionalOneToMandatoryMany.jet does. The best way to see the difference is to view them in eclipse, where association_SetOptionalOneToMandatoryMany has a blank line at the end, but association_AddImmutableUnidirectionalMany doesn't. Then, contrast this with looking at them in Github (association_SetOptionalOneToMandatoryMany vs association_AddImmutableUnidirectionalMany
The issue that occurs is that, in JET, the newline at the end of the last line is counted as an additional newline. However, the Java parsing does not differentiate between a final line ending with a newline vs a final line ending with the EOF character. This means that when translating from JET to Umple, there are some inconsistencies between certain files.
This just needs to be handled for PureText parsing, in the special case started by if (line == null && containsOnlySpaces(previousLine)) {. Because of how many files are affected by this, it is possible that the relevant special case should not be kept, or will need to be vastly changed.
Please note that one difficulty with dealing with this issue is how vim (as well as possibly other editors) will automatically insert a newline at the end of the file, while Eclipse will not and instead displays it (so some files will appear to have an additional line at the end of the file).
The text was updated successfully, but these errors were encountered:
For the JET templates that we used in Umple originally, some ended with a newline, while others didn't. (http://stackoverflow.com/questions/5813311/no-newline-at-end-of-file).
For example, the Java test template files association_AddImmutableUnidirectionalMany.jet does not have a newline at the end, while association_SetOptionalOneToMandatoryMany.jet does. The best way to see the difference is to view them in eclipse, where association_SetOptionalOneToMandatoryMany has a blank line at the end, but association_AddImmutableUnidirectionalMany doesn't. Then, contrast this with looking at them in Github (association_SetOptionalOneToMandatoryMany vs association_AddImmutableUnidirectionalMany
The issue that occurs is that, in JET, the newline at the end of the last line is counted as an additional newline. However, the Java parsing does not differentiate between a final line ending with a newline vs a final line ending with the EOF character. This means that when translating from JET to Umple, there are some inconsistencies between certain files.
This just needs to be handled for PureText parsing, in the special case started by
if (line == null && containsOnlySpaces(previousLine)) {
. Because of how many files are affected by this, it is possible that the relevant special case should not be kept, or will need to be vastly changed.Please note that one difficulty with dealing with this issue is how vim (as well as possibly other editors) will automatically insert a newline at the end of the file, while Eclipse will not and instead displays it (so some files will appear to have an additional line at the end of the file).
The text was updated successfully, but these errors were encountered: