Skip to content

display validation on save + use uui-color-invalid

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev) failed Feb 10, 2025 in 42s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Prevent hotspot decline (1 hotspot with Large Method)
Enforce critical code health rules (1 file with Bumpy Road Ahead)
Enforce advisory code health rules (2 files with Complex Method, Large Method)

Gates Passed
1 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Prevent hotspot decline Violations Code Health Impact
document-workspace.context.ts 1 rule in this hotspot 9.19 → 9.19 Suppress
Enforce critical code health rules Violations Code Health Impact
content-detail-workspace-base.ts 1 critical rule 9.19 → 9.02 Suppress
Enforce advisory code health rules Violations Code Health Impact
content-detail-workspace-base.ts 1 advisory rule 9.19 → 9.02 Suppress
document-workspace.context.ts 1 advisory rule 9.19 → 9.19 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method document-workspace.context.ts: UmbDocumentWorkspaceContext.constructor 🔥
  • Complex Method content-detail-workspace-base.ts: _handleSubmit
  • Complex Method content-detail-workspace-base.ts: constructor
  • Bumpy Road Ahead content-detail-workspace-base.ts: _handleSubmit

✅ Improving Code Health:

  • Large Method content-detail-workspace-base.ts: constructor

Annotations

Check warning on line 626 in src/Umbraco.Web.UI.Client/src/packages/core/content/workspace/content-detail-workspace-base.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ Getting worse: Complex Method

_handleSubmit increases in cyclomatic complexity from 13 to 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 168 in src/Umbraco.Web.UI.Client/src/packages/core/content/workspace/content-detail-workspace-base.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Method

constructor has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in src/Umbraco.Web.UI.Client/src/packages/core/content/workspace/content-detail-workspace-base.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

✅ No longer an issue: Large Method

constructor is no longer above the threshold for lines of code

Check warning on line 626 in src/Umbraco.Web.UI.Client/src/packages/core/content/workspace/content-detail-workspace-base.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Bumpy Road Ahead

_handleSubmit has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 84 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace.context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ Getting worse: Large Method

UmbDocumentWorkspaceContext.constructor increases from 93 to 94 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.