volume_status module: pamixer: Use default device if none specified #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not specifying the device should use whatever pamixer thinks is the default. Using 0 might not be always the default, especially because the default (or whatever pamixer thinks is the default) can change at runtime.
lasers
approved these changes
Jan 15, 2024
|
Thanks! |
lasers
reviewed
Jan 18, 2024
| @@ -172,7 +172,7 @@ def toggle_mute(self): | |||
| class Pamixer(Audio): | |||
| def setup(self, parent): | |||
| is_input = "--source" if self.is_input else "--sink" | |||
| self.cmd = ["pamixer", "--allow-boost", is_input, self.device or "0"] | |||
| self.cmd = ["pamixer", "--allow-boost"] + ([is_input, self.device] if self.device else []) | |||
There was a problem hiding this comment.
Sorry, I'm rusty. This doesn't respect device = 0.
- self.cmd = ["pamixer", "--allow-boost"] + ([is_input, self.device] if self.device else [])
+ self.cmd = ["pamixer", "--allow-boost"] + ([is_input, self.device] if self.device is not None else [])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not specifying the device should use whatever pamixer thinks is the default. Using 0 might not be always the default, especially because the default (or whatever pamixer thinks is the default) can change at runtime.