New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should store only lowercase usernames and emails #48

Open

ctgraham opened this issue Aug 9, 2024 · 0 comments

Member

ctgraham commented Aug 9, 2024

In the release for 3.3, we should key on lowercase usernames:

pkp-betterPassword/classes/BadpwFailedLoginsDAO.php

Line 64 in 1a7a297

WHERE username = ?

Core enforces the lowercasing here:
https://github.com/pkp/pkp-lib/blob/edeb7094764d7c289796fef23116a916e80716a2/classes/user/DAO.php#L230

Also for 3.4 with usernames and emails:
https://github.com/pkp/pkp-lib/blob/edeb7094764d7c289796fef23116a916e80716a2/classes/user/DAO.php#L230
https://github.com/pkp/pkp-lib/blob/edeb7094764d7c289796fef23116a916e80716a2/classes/user/DAO.php#L248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment