Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor updates in the Site::setMinPasswordLength #18

Open
jonasraoni opened this issue Feb 4, 2021 · 2 comments
Open

Monitor updates in the Site::setMinPasswordLength #18

jonasraoni opened this issue Feb 4, 2021 · 2 comments

Comments

@jonasraoni
Copy link
Contributor

Since the cache is discarding smaller passwords, we need to monitor changes in this setting (or inflate the cache with small passwords), that could happen outside the plugin.

Still talking about the cache... If we sort the hashes before storing them into the disk, we could use a binary-search instead of using the opcache. But I think it's not worth, unless the file is huge :D

@ctgraham
Copy link
Member

ctgraham commented Feb 4, 2021

I think the cache should be dependent on the Site's minPasswordLength setting. If the setting changes, the cache is invalid and needs to be recreated.

@jonasraoni
Copy link
Contributor Author

Yep, I've added a local check here, but I think it should be done through a hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants