Ml combine proc #96
Merged
Ml combine proc #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lara813
force-pushed
the
ML_combine_proc
branch
from
3b4da29 to
e06606a
Compare
mafrahm
reviewed
Dec 10, 2024
Comment on lines
+216
to
+217
| id=randint(10000000, 99999999), | ||
| # TODO: random number (could by chance be a already used number --> should be checked) |
There was a problem hiding this comment.
I think the bigger problem might be that this number changes every time we re-run this code. We could create some reproducible id via some hash function, similar as it is done here: https://github.com/columnflow/columnflow/blob/master/columnflow/config_util.py#L328
mafrahm
reviewed
Dec 10, 2024
mafrahm
reviewed
Dec 10, 2024
mafrahm
reviewed
Dec 10, 2024
mafrahm
reviewed
Dec 10, 2024
mafrahm
reviewed
Dec 10, 2024
mafrahm
reviewed
Dec 10, 2024
mafrahm
reviewed
Dec 10, 2024
mafrahm
reviewed
Dec 10, 2024
|
|
||
| combining_proc = [] | ||
| for proc in proc_dict.sub_processes: | ||
| combining_proc.append(config.get_process(proc, default=None)) |
There was a problem hiding this comment.
what happens when we cannot find the corresponding process (adding None)?
mafrahm
reviewed
Dec 10, 2024
mafrahm
reviewed
Dec 10, 2024
mafrahm
reviewed
Dec 10, 2024
law.cfg
Outdated
| @@ -56,7 +56,7 @@ slurm_flavor: $CF_SLURM_FLAVOR | |||
| slurm_partition: $CF_SLURM_PARTITION | |||
|
|
|||
| # ChunkedIOHandler defaults | |||
| chunked_io_chunk_size: 100000 | |||
| chunked_io_chunk_size: 50000 | |||
There was a problem hiding this comment.
can you remove the changes in this file?
Co-authored-by: Mathis Frahm <49306645+mafrahm@users.noreply.github.com>
Co-authored-by: Mathis Frahm <49306645+mafrahm@users.noreply.github.com>
mafrahm
reviewed
Dec 11, 2024
mafrahm
reviewed
Dec 11, 2024
mafrahm
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to combine processes for ML Training and additionally define the desired weighting approach. Also modified stats accordingly.
Additionally introduced two ML and Inference models that combine GGF and VBF signal with both weighting approaches