Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLEvaluation runs twice when creating datacards #85

Open
mafrahm opened this issue Sep 13, 2024 · 0 comments
Open

MLEvaluation runs twice when creating datacards #85

mafrahm opened this issue Sep 13, 2024 · 0 comments
Labels
low-priority Low priority stuff

Comments

@mafrahm
Copy link
Collaborator

mafrahm commented Sep 13, 2024

Due to the structure of our workflow (using cf.MLEvaluation to create categories in cf.ProduceColumns), it currently happens that cf.MLEvaluation runs once without and once with requiring this particular category Producer.

This issue might be solved by removing the MLModel from the command line when calling cf.CreateDatacards (which is resolved automatically at the moment). However, this also means that the ML output columns would not be loaded and that the MLTraining init might not be running.
Solutions:

  • add the produced columns from the MLTraining both in uses and produces of the category Producer
  • run the MLTraining init function in the category Producer init aswell
@mafrahm mafrahm added the low-priority Low priority stuff label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-priority Low priority stuff
Projects
None yet
Development

No branches or pull requests

1 participant