update GF/C3 for SRW3.0 release #249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haiqinli
requested review from
grantfirl,
rhaesung,
Qingfu-Liu,
dustinswales and
lisa-bengtsson
as code owners
This was referenced Jan 28, 2025
grantfirl
reviewed
Feb 7, 2025
|
|
||
| integer :: itemp | ||
| !$acc declare create(p_liq_ice,melting_layer,melting,buoysrc,beta_x,vcpool,wlpool,umcl,vmcl) |
There was a problem hiding this comment.
Has this change in openACC pragma been tested with nvfortran?
There was a problem hiding this comment.
We added these new arrays following the existing arrays of "p_liq_ice,melting_layer,melting", but no opportunity to test it with nvfortran. Thanks.
grantfirl
approved these changes
Feb 7, 2025
rhaesung
approved these changes
Feb 10, 2025
Qingfu-Liu
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the GF/C3 for the SRW 3.0.0 release. It includes some of the GF/C3 updates implemented for RRFSv1 and still was successful in reproducing predicted severe storms. It also includes the simplified cold pool parameterization for C3.