New version picker for stable #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added version switch * added changeset
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Don't merge yet as we're still need to adjust 1-2 env variables for the NEXT deployment. |
alexvcasillas
approved these changes
Apr 16, 2025
arnaugomez
approved these changes
Apr 16, 2025
| import { VERSIONS, CURRENT_VERSION } from '@/utils/constants' | ||
| import type { VersionData } from '@/types' | ||
|
|
||
| const getItemLabel = ({ version }: { version: VersionData }) => { |
There was a problem hiding this comment.
I believe the argument can be simplified to (version: VersionData)
When the selector is open, the area on top of "2x" has a styling of cursor: normal instead of cursor: pointer (this is a nitpick, you can ignore it).
|
I think it's actually correct as the menu disabled any interaction with everything not the menu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.