Merge pull request #18 from stopfstedt/dedupe-sorting-by-anoncode

apply quiz scope when joining on usercodes table to prevent duplicate…
ucsf-education · Jan 17, 2025 · 7c885a4 · 7c885a4
2 parents a586c71 + 449170f
commit 7c885a4
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/report/grading/report.php b/report/grading/report.php
@@ -335,7 +335,8 @@ protected function get_usage_ids_where_question_in_state($summarystate, $slot,
                     ) as tcreated";
             $orderby = "tcreated";
         } else if ($orderby === 'usercode') {
-            $qubaids->from .= " JOIN {local_quizanon_usercodes} lqau ON lqau.userid = quiza.userid";
+            $qubaids->from
+                .= " JOIN {local_quizanon_usercodes} lqau ON lqau.userid = quiza.userid AND quiza.quiz = lqau.quizid";
             $orderby = 'lqau.code';
         }
         return $dm->load_questions_usages_where_question_in_state($qubaids, $summarystate,