Fix/fence yaml merge #183
Merged
Fix/fence yaml merge #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version bump gen3 chart version bump fence public config
cleanup
…C in the values.yaml Changing the manifest-fence configmap to fence-config-public.yaml so it is properly mounted in the container. Editing presigned URL to save the fence public config to a file.
…ronment var. Also, changing the file name for the fence-config to avoid breaking changes.
jawadqur
approved these changes
Jul 2, 2024
Thank you! Yes, just updated base branch and it looks like there are no conflicts :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of https://github.com/uc-cdis/gen3-helm/pull/151/files
Changes added on to PR 151:
Adjusting the fence public config so it pulls from FENCE_CONFIG_PUBLIC in the values.yaml.
Changing the manifest-fence configmap to "fence-config-public.yaml" so it is properly mounted in the container.
Editing presigned URL to save the fence public config to a file.
New Features
Users will now have the ability to keep sensitive Fence configurations separate from Fence public configurations.