-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PPS-635): chore(security): update urllib3 and related deps #1132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked this branch out locally in a fresh venv, ran poetry install without issue. pytest ran without issue (just confirming things GH actions already told us hahaha)
Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: See #1132 (comment)
I have some concerns about the storage client abstraction. Given this is a security issue wiht a limited timeframe, its not a show stopper.
However, TODOs should be associated with JIRA tickets, especially ones related to input sanitization.
Resolving previous comments related to storageclient. This was copy and pasted from a separate repo. Making changes in this PR to address issues that have been around previously will muddy the waters in tracing issues from Fence to the previous repo. |
https://ctds-planx.atlassian.net/browse/PXP-11238 Ticket to do storageclient cleanup in the future on a separate PR |
Jira Tickets:
Relies on:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes