Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull resources from auth_mapping #1122

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Pull resources from auth_mapping #1122

merged 1 commit into from
Nov 17, 2023

Conversation

k-burt-uch
Copy link
Contributor

@k-burt-uch k-burt-uch commented Nov 16, 2023 •
edited by jira bot
Loading

Link to JIRA Issue: PXP-11181

New Features

Breaking Changes

Bug Fixes

  • Fixes issue where users not present in arborist would have blank resources and authz fields when they should have values for open access data within the commons.

Improvements

Dependency updates

Deployment changes

@k-burt-uch k-burt-uch marked this pull request as ready for review November 16, 2023 21:31
Avantol13
Avantol13 requested changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@Avantol13 Avantol13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks good but can we add a regression test where we simulate list_resources_for_user raising a 404, hitting userinfo, and make sure the keys from auth_mapping are in the response?

@k-burt-uch k-burt-uch force-pushed the fix/authz-does-not-include-open-access-for-some-users branch from 760e55b to e949383 Compare November 16, 2023 23:34
@k-burt-uch
fix(PXP-11181): Fix empty authz for users missing in arborist
beefc2d 
Remove list_resource_for_user from get_user_info
@k-burt-uch k-burt-uch force-pushed the fix/authz-does-not-include-open-access-for-some-users branch from e949383 to beefc2d Compare November 16, 2023 23:51
@k-burt-uch k-burt-uch requested a review from Avantol13 November 16, 2023 23:54
@k-burt-uch k-burt-uch merged commit e11eb66 into master Nov 17, 2023
@k-burt-uch k-burt-uch deleted the fix/authz-does-not-include-open-access-for-some-users branch November 17, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avantol13 Avantol13 Avantol13 approved these changes

Assignees
No one assigned
Labels
test-apis-centralizedAuth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-burt-uch @Avantol13 @PlanXCyborg