feat: use pod_id as the ssid of the wifi hotspot

CHANGELOG.md

@@ -12,6 +12,7 @@
 - fix: add ".local" to hostname in users menus - closes #134
 - fix: use stdout instead of stderr for reading rpi-connect process output - closes #174
 - feat: setup a wifi hotspot for when the a web-ui input is demanded and the device is not connected to any network - closes #169
+- feat: use `pod_id` as the ssid of the wifi hotspot
 
 ## Version 1.1.0
 

ubo_app/logging.py

@@ -1,3 +1,4 @@
+# noqa: A005, FIX002 # TODO(@sassanh): remove A105 when fix is merged
 # ruff: noqa: D100, D101, D102, D103, D104, D107
 from __future__ import annotations
 

ubo_app/system/system_manager/hotspot.py

@@ -3,6 +3,8 @@
 import pathlib
 import subprocess
 
+from ubo_app.utils.pod_id import get_pod_id
+
 
 def hotspot_handler(desired_state: str) -> None:
     """Set up a hotspot on the UBO."""
@@ -15,9 +17,9 @@ def hotspot_handler(desired_state: str) -> None:
             f.write("""interface=wlan0
 dhcp-range=192.168.4.2,192.168.4.20,255.255.255.0,24h""")
         with pathlib.Path('/etc/hostapd/hostapd.conf').open('w') as f:
-            f.write("""interface=wlan0
+            f.write(f"""interface=wlan0
 driver=nl80211
-ssid=UBO
+ssid={get_pod_id()}
 hw_mode=g
 channel=7
 wpa=2

ubo_app/system/system_manager/main.py

@@ -30,6 +30,7 @@
 from ubo_app.system.system_manager.service_manager import service_handler
 from ubo_app.system.system_manager.users import users_handler
 from ubo_app.utils.eeprom import read_serial_number
+from ubo_app.utils.pod_id import get_pod_id, set_pod_id
 
 SOCKET_PATH = Path(os.environ.get('RUNTIME_DIRECTORY', '/run/ubo')).joinpath(
     'system_manager.sock',
@@ -96,7 +97,6 @@ def process_request(command: bytes, connection: socket.socket) -> None:
 def setup_hostname() -> None:
     """Set the hostname to 'ubo'."""
     logger.info('Setting hostname...')
-    from ubo_app.constants import INSTALLATION_PATH
 
     thread = Thread(target=check_connection)
     thread.start()
@@ -105,16 +105,14 @@ def setup_hostname() -> None:
         set(string.ascii_lowercase + string.digits + '-') - set('I1lO'),
     )
 
-    id_path = Path(INSTALLATION_PATH) / 'pod-id'
-
-    if not id_path.exists():
+    if not get_pod_id():
         serial_number = read_serial_number()
         random.seed(serial_number)
         # Generate 2 letters random id
         id = f'ubo-{"".join(random.sample(available_letters, 2))}'
-        id_path.write_text(id)
+        set_pod_id(id)
 
-    id = id_path.read_text().strip()
+    id = get_pod_id()
 
     # Set hostname of the system
     subprocess.run(  # noqa: S603

ubo_app/utils/pod_id.py

@@ -0,0 +1,20 @@
+"""Module for managing the pod ID."""
+
+import pathlib
+
+from ubo_app.constants import INSTALLATION_PATH
+
+id_path = pathlib.Path(INSTALLATION_PATH) / 'pod-id'
+
+
+def get_pod_id() -> str | None:
+    """Return the pod ID."""
+    try:
+        return id_path.read_text().strip()
+    except FileNotFoundError:
+        return None
+
+
+def set_pod_id(pod_id: str) -> None:
+    """Set the pod ID."""
+    id_path.write_text(pod_id)

ubo_app/utils/secrets.py

@@ -1,3 +1,4 @@
+# noqa: A005, FIX002 # TODO(@sassanh): remove A105 when fix is merged
 """Module to manage secrets in a .env file."""
 
 from __future__ import annotations