From 8c2dca7889b19149dc8b2ec365476b2adee85d0a Mon Sep 17 00:00:00 2001 From: Mikael Arguedas Date: Thu, 14 Nov 2024 10:37:27 +0100 Subject: [PATCH 1/3] [CI] add noble to testing matrix Signed-off-by: Mikael Arguedas --- .github/workflows/ci.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index f51beaa0..41f63f17 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -65,6 +65,7 @@ jobs: - { DEB_DISTRO: bookworm, DEBS: true, VERBOSE: bloom } - { DEB_DISTRO: jammy, VERBOSE: true } - { DEB_DISTRO: jammy, BUILD_TIMEOUT: 3, ROS_SOURCES: 'good', DEBS: true, EXPECT_EXIT_CODE: 143 } + - { DEB_DISTRO: noble, VERBOSE: true } # add failing jobs - { DEB_DISTRO: focal, ROS_SOURCES: broken, EXPECT_EXIT_CODE: 2, CONTINUE_ON_ERROR: false, DEBS: true } - { DEB_DISTRO: focal, ROS_SOURCES: broken, EXPECT_EXIT_CODE: 1, CONTINUE_ON_ERROR: true, COLCON_PKG_SELECTION: '--packages-up-to rostime' } From 346cea99359238aec2cd6a5115da8b4c63640927 Mon Sep 17 00:00:00 2001 From: Robert Haschke Date: Thu, 14 Nov 2024 11:10:31 +0100 Subject: [PATCH 2/3] Add noble to matrix --- .github/workflows/ci.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 41f63f17..2820c408 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -56,16 +56,15 @@ jobs: strategy: fail-fast: false matrix: - DEB_DISTRO: [ bookworm, jammy ] + DEB_DISTRO: [ bookworm, jammy, noble ] BUILD_TIMEOUT: [ 0 ] include: # defaults (can be overriden with values from include w/o adding jobs) - { ROS_SOURCES: 'good', DEBS: false, VERBOSE: false } # override/add settings for specific distros - { DEB_DISTRO: bookworm, DEBS: true, VERBOSE: bloom } - - { DEB_DISTRO: jammy, VERBOSE: true } - - { DEB_DISTRO: jammy, BUILD_TIMEOUT: 3, ROS_SOURCES: 'good', DEBS: true, EXPECT_EXIT_CODE: 143 } - { DEB_DISTRO: noble, VERBOSE: true } + - { DEB_DISTRO: jammy, BUILD_TIMEOUT: 3, ROS_SOURCES: 'good', DEBS: true, EXPECT_EXIT_CODE: 143 } # add failing jobs - { DEB_DISTRO: focal, ROS_SOURCES: broken, EXPECT_EXIT_CODE: 2, CONTINUE_ON_ERROR: false, DEBS: true } - { DEB_DISTRO: focal, ROS_SOURCES: broken, EXPECT_EXIT_CODE: 1, CONTINUE_ON_ERROR: true, COLCON_PKG_SELECTION: '--packages-up-to rostime' } From 5bbfe0180552a62ba76a6ac9c349751e7f2cf65c Mon Sep 17 00:00:00 2001 From: Robert Haschke Date: Thu, 14 Nov 2024 12:09:35 +0100 Subject: [PATCH 3/3] Build noble docker images --- .github/workflows/docker.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/docker.yaml b/.github/workflows/docker.yaml index 254138e6..3d409707 100644 --- a/.github/workflows/docker.yaml +++ b/.github/workflows/docker.yaml @@ -21,7 +21,7 @@ jobs: strategy: fail-fast: false matrix: - DEB_DISTRO: [jammy] + DEB_DISTRO: [jammy, noble] ROS_DISTRO: [one] uses: ./.github/workflows/docker.build.yaml @@ -37,7 +37,7 @@ jobs: strategy: fail-fast: false matrix: - DEB_DISTRO: [jammy] + DEB_DISTRO: [jammy, noble] uses: ./.github/workflows/docker.build.yaml secrets: inherit @@ -52,7 +52,7 @@ jobs: strategy: fail-fast: false matrix: - DEB_DISTRO: [jammy] + DEB_DISTRO: [jammy, noble] uses: ./.github/workflows/docker.build.yaml secrets: inherit @@ -67,7 +67,7 @@ jobs: strategy: fail-fast: false matrix: - DEB_DISTRO: [jammy] + DEB_DISTRO: [jammy, noble] uses: ./.github/workflows/docker.build.yaml secrets: inherit @@ -82,7 +82,7 @@ jobs: strategy: fail-fast: false matrix: - DEB_DISTRO: [jammy] + DEB_DISTRO: [jammy, noble] uses: ./.github/workflows/docker.build.yaml secrets: inherit @@ -97,7 +97,7 @@ jobs: strategy: fail-fast: false matrix: - DEB_DISTRO: [jammy] + DEB_DISTRO: [jammy, noble] uses: ./.github/workflows/docker.build.yaml secrets: inherit