Skip to content

Commit

Permalink
revert learner_1/2 qini_score calc
Browse files Browse the repository at this point in the history
  • Loading branch information
rolandrmgservices committed Nov 29, 2023
1 parent 1481823 commit c80cab6
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions tests/test_metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,10 @@ def test_qini_score():
full_result = qini_score(test_df)

# get qini score for learner_1 separately
learner_1_result = qini_score(
test_df[["y", "w", "learner_1"]], treatment_effect_col="learner_1"
)
learner_1_result = qini_score(test_df[["y", "w", "learner_1"]])

# get qini score for learner_2 separately
learner_2_result = qini_score(
test_df[["y", "w", "learner_2"]], treatment_effect_col="learner_2"
)
learner_2_result = qini_score(test_df[["y", "w", "learner_2"]])

# for each learner, its qini score should stay same no matter calling with another model or calling separately
assert isclose(full_result["learner_1"], learner_1_result["learner_1"])
Expand Down

0 comments on commit c80cab6

Please sign in to comment.