Remove internal package from interface type to be potentially impleme… (#14)

* Remove internal package from interface type to be potentially implemented by thrid-party users

* Provide logger for UnmarshalConfig

Author: Vasilis

bootstrap.go

@@ -81,7 +81,7 @@ func Run(ec *config.Extended, opts ...Option) {
 		os.Exit(1)
 	}
 
-	sr, err := gl.App.Metrics.NewReporter(logger)
+	sr, err := gl.App.Metrics.NewReporter(logger.Logger)
 	if err != nil {
 		logger.Error("error initializing stats", zap.Error(err))
 	}

config/config.go

@@ -202,7 +202,7 @@ func Get(cc *CLIConfig, ec *Extended, logger *log.Logger) (*AppConfig, error) {
 		return nil, err
 	}
 
-	mc, err := ec.Metrics.UnmarshalConfig(data, *cc.ConfigFile)
+	mc, err := ec.Metrics.UnmarshalConfig(data, *cc.ConfigFile, logger.Logger)
 	if err != nil {
 		return nil, err
 	}

metrics/metrics.go

@@ -23,17 +23,17 @@ package metrics
 import (
 	"time"
 
-	"github.com/uber/arachne/internal/log"
+	"go.uber.org/zap"
 )
 
 // Opt is an interface for config unmarshaled in local configuration files.
 type Opt interface {
-	UnmarshalConfig(data []byte, fname string) (Config, error)
+	UnmarshalConfig(data []byte, fname string, logger *zap.Logger) (Config, error)
 }
 
 // Config is an interface for creating metrics-specific stats reporters.
 type Config interface {
-	NewReporter(logger *log.Logger) (Reporter, error)
+	NewReporter(logger *zap.Logger) (Reporter, error)
 }
 
 // Tags is an alias of map[string]string, a type for tags associated with a statistic.

metrics/metrics_statsd.go

@@ -24,8 +24,6 @@ import (
 	"fmt"
 	"time"
 
-	"github.com/uber/arachne/internal/log"
-
 	"github.com/DataDog/datadog-go/statsd"
 	"github.com/pkg/errors"
 	"go.uber.org/zap"
@@ -72,7 +70,7 @@ var (
 )
 
 // UnmarshalConfig fetches the configuration file from local path.
-func (c StatsdConfiger) UnmarshalConfig(data []byte, fname string) (Config, error) {
+func (c StatsdConfiger) UnmarshalConfig(data []byte, fname string, logger *zap.Logger) (Config, error) {
 
 	cfg := new(StatsdConfig)
 	if err := yaml.Unmarshal(data, cfg); err != nil {
@@ -89,7 +87,7 @@ func (c StatsdConfiger) UnmarshalConfig(data []byte, fname string) (Config, erro
 }
 
 // NewReporter creates a new metrics backend talking to Statsd.
-func (c StatsdConfig) NewReporter(logger *log.Logger) (Reporter, error) {
+func (c StatsdConfig) NewReporter(logger *zap.Logger) (Reporter, error) {
 	s, err := statsd.New(c.Metrics.Statsd.HostPort)
 	if err != nil {
 		return nil, err