Fix Histogram bucket counter metric sizing (#154)

uber-go · May 11, 2021 · e322209 · e322209
1 parent b7bc80a
commit e322209
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/m3/reporter.go b/m3/reporter.go
@@ -356,6 +356,7 @@ func (r *reporter) AllocateHistogram(
 				durationUpperBound: pair.UpperBoundDuration(),
 				metric:             counter,
 			}
+			delta = len(r.bucketIDTagName) + len(r.bucketTagName) + len(idTagValue)
 		)
 
 		hbucket.metric.metric.Tags = append(
@@ -371,14 +372,16 @@ func (r *reporter) AllocateHistogram(
 
 		bucketIdx := len(hbucket.metric.metric.Tags) - 1
 		if isDuration {
-			hbucket.metric.metric.Tags[bucketIdx].Value =
-				r.durationBucketString(pair.LowerBoundDuration()) +
-					"-" + r.durationBucketString(pair.UpperBoundDuration())
+			bname := r.durationBucketString(pair.LowerBoundDuration()) + "-" +
+				r.durationBucketString(pair.UpperBoundDuration())
+			hbucket.metric.metric.Tags[bucketIdx].Value = bname
+			hbucket.metric.size += int32(delta + len(bname))
 			cachedDurationBuckets = append(cachedDurationBuckets, hbucket)
 		} else {
-			hbucket.metric.metric.Tags[bucketIdx].Value =
-				r.valueBucketString(pair.LowerBoundValue()) +
-					"-" + r.valueBucketString(pair.UpperBoundValue())
+			bname := r.valueBucketString(pair.LowerBoundValue()) + "-" +
+				r.valueBucketString(pair.UpperBoundValue())
+			hbucket.metric.metric.Tags[bucketIdx].Value = bname
+			hbucket.metric.size += int32(delta + len(bname))
 			cachedValueBuckets = append(cachedValueBuckets, hbucket)
 		}
 	}