Keep suggesting index on incoming message #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So it removes the sender from suggestions when a new message arrives (makes sense), but this also updated the currently shown suggestion regardless of whether it was a from someone in the previous suggestions? |
|
The fix is that if whoever sent the message is not removed from the suggestions then keep it as it is |
|
(it being the suggestion index) |
|
Seems good. In the less likely event that it was someone from the suggestions, but not the one you're currently staring, it will still jump? (or even in the case that it was the person you're staring, but then it makes sense anyway) |
|
it should move only if the index matches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #254