Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another Trace Example #155

Merged
merged 11 commits into from
Mar 23, 2023
Merged

Add another Trace Example #155

merged 11 commits into from
Mar 23, 2023

Conversation

zmccoy
Copy link
Member

@zmccoy zmccoy commented Mar 20, 2023

This adds an example for showing how a client, database, and trait that utilizes both of them may interact. It tries to highlight the ways to add attributes to spans as well as different methods that can be used.

@zmccoy zmccoy requested review from rossabaker and iRevive March 20, 2023 17:55
Copy link
Contributor

@iRevive iRevive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me. I have only two minor comments.

examples/src/main/scala/TraceExample.scala Outdated Show resolved Hide resolved
examples/src/main/scala/TraceExample.scala Outdated Show resolved Hide resolved
@zmccoy zmccoy requested a review from armanbilge March 21, 2023 16:53
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding examples, very excited about everyone's work here!!

@zmccoy
Copy link
Member Author

zmccoy commented Mar 21, 2023

Just discovered a Parallel I missed, I'll nab that too. And a bad comment, I apparently missed a lot 😿

@armanbilge
Copy link
Member

Was going to make a ticket, but seems it already exists! 😆

@zmccoy zmccoy merged commit 27e5057 into typelevel:main Mar 23, 2023
@zmccoy zmccoy deleted the add-trace-example branch March 23, 2023 14:19
chr12c pushed a commit to chr12c/otel4s that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants