-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add another Trace Example #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me. I have only two minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding examples, very excited about everyone's work here!!
Just discovered a Parallel I missed, I'll nab that too. And a bad comment, I apparently missed a lot 😿 |
Was going to make a ticket, but seems it already exists! 😆 |
This adds an example for showing how a client, database, and trait that utilizes both of them may interact. It tries to highlight the ways to add attributes to spans as well as different methods that can be used.