Fix: VortexViewReader sometimes can't extract VortexSystem #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
VortexViewReader
cannot extractVortexSystem
whenVortexView
has a sibling ofForEach
view that is inside a layout container (for example,HStack { ForEach... }
) or aTextField
view (Mentioned in #20), which causes functions onVortexProxy
fail to run (for example,VortexProxy.burst()
).This issue was addressed by #19 but wasn't merged because it will cause
VortexViewReader
to read the lastVortexSystem
rather than the first when it contains multipleVortexView
.Minimal Reproducible Example
Result
This slightly modified pull request allows
VortexViewReader
to extract the firstVortexSystem
in the above situation.And thanks for making this awesome library :D