install.sh,update.sh,README.md: Run without sudo

Author: twojstaryzdomu

README.md

@@ -205,18 +205,12 @@ _Note: this assumes a clean Debian install, and there is no rollback method_
 
 ### Curl install scripts
 
-This is executed as `root` as indicated by the `#`
+This script will be executed as `root`, `sudo` is not necessary
 
 ```
 # curl -sSL https://raw.githubusercontent.com/nextcloud/nextcloudpi/master/install.sh | bash
 ```
 
-If you're not `root` you can run it with `sudo` like so
-
-```
-curl -sSL https://raw.githubusercontent.com/nextcloud/nextcloudpi/master/install.sh | sudo bash
-```
-
 ### Environment variables for install.sh
 
 Environment variables control the installation process.
@@ -231,10 +225,10 @@ When set to any value:
 - `REINIT` - re-initialise the configuration from scratch: drop NC database & user environment
 - `NCDATA` - overrides the NC data directory, defined in `etc/ncp-config.d/nc-datadir.cfg`
 
-NOTE: `sudo -E` is needed to source non-root user environment i.e.
+NOTE: `sudo -E` is normally needed to gain root and to source non-root user environment but not required here
 
 ```
-CODE_DIR=. NOUPDATE=1 NCHOSTNAME=my_own_hostname sudo -E bash install.sh
+CODE_DIR=. NOUPDATE=1 NCHOSTNAME=my_own_hostname | bash install.sh
 ```
 
 Also, for debug purposes:

install.sh

@@ -12,16 +12,16 @@
 BRANCH="${BRANCH:-master}"
 #DBG=x
 
+[[ ${EUID} -ne 0 ]] && {
+  sudo -E bash $0
+  exit $?
+}
+
 set -e$DBG
 
 TEMPDIR="$(mktemp -d /tmp/nextcloudpi.XXXXXX || (echo "Failed to create temp dir. Exiting" >&2 ; exit 1) )"
 trap "rm -rf \"${TEMPDIR}\"" 0 1 2 3 15
 
-[[ ${EUID} -ne 0 ]] && {
-  printf "Must be run as root. Try 'sudo $0'\n"
-  exit 1
-}
-
 export PATH="/usr/local/sbin:/usr/sbin:/sbin:${PATH}"
 
 # check installed software

update.sh

@@ -8,6 +8,11 @@
 # More at https://ownyourbits.com/
 #
 
+[[ ${EUID} -ne 0 ]] && {
+  sudo -E $0
+  exit $?
+}
+
 source /usr/local/etc/library.sh
 
 set -e$DBG